[webkit-reviews] review granted: [Bug 14997] Support for server-sent DOM events : [Attachment 31160] updated patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 14997: Support for server-sent DOM events
https://bugs.webkit.org/show_bug.cgi?id=14997

Attachment 31160: updated patch
https://bugs.webkit.org/attachment.cgi?id=31160&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>

> +static JSObject* constructEventSource(ExecState* exec, JSObject*
constructor, const ArgList& args)
> +{
> +    if (args.size() == 0)
> +	   return throwError(exec, SyntaxError, "Not enough arguments");

Out approach is ussually to just all the the toString conversion go to work on
the undefined value instead of checking the number of args here. Is this called
out for specifically in the spec?

One thing we should definitely look into doing is writing a fuzzer for this new
parser.  Otherwise, this looks great, thanks for keeping it up to date and
hanging in there for this ridiculous long time. r=me.