[webkit-reviews] review requested: [Bug 27181] StorageArea should only contain methods we intend to proxy : [Attachment 32828] v1

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27181: StorageArea should only contain methods we intend to proxy
https://bugs.webkit.org/show_bug.cgi?id=27181

Attachment 32828: v1
https://bugs.webkit.org/attachment.cgi?id=32828&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
StorageArea should only contain methods we intend to proxy.
https://bugs.webkit.org/show_bug.cgi?id=27181

Right now, StorageAreaSync takes in a StorageArea* and calls methods
like importItem.  Really, StorageAreaSync should be operating directly
on StorageAreaImpl* and those methods should be removed from StorageArea
since StorageAreaSync should never be attached to anything other than a
StorageAreaImpl.
This was pointed out in the review for
https://bugs.webkit.org/show_bug.cgi?id=27072

Also clean up StorageNamespaceImpl to operate directly on
StorageAreaImpl.  Also, get rid of the factory for StorageArea
since nothing should ever create a StorageArea directly.