[webkit-reviews] review requested: [Bug 16401] [GTK] GObject/C DOM binding : [Attachment 32807] answering comments in #194 by sam

[bugzilla-daemon at webkit.org]

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 16401: [GTK] GObject/C DOM binding
https://bugs.webkit.org/show_bug.cgi?id=16401

Attachment 32807: answering comments in #194 by sam
https://bugs.webkit.org/attachment.cgi?id=32807&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
ok - sam, this is answering the question about why CustomGetter, CustomSetter
and Custom are used.  if you don't then there are three (that i could find,
through compile-errors) properties that have to be skipped; i just skip
anything of type "Event"; anything of type "Object" and
JavaScriptCallFrame.type.

i'm not sure of the wisdom of skipping everything of type "Event", it may be
wiser to skip only "DOMWindow.event" but i wanted to solicit your approval for
this technique of removing the references to CustomGetter, CustomSetter and
Custom in favour of very specific statements like this:

+	 # skip JavaScriptCallFrame.type
+	 if (($prop_name eq "type") && ($interfaceName eq
"JavaScriptCallFrame")){
+	     next SKIPPROP;
+	 }

there aren't tooooo many of these, as you can see, but it can also be seen that
they are, right now, entirely necessary.  and the patch size is kept down as a
result.

l.