[webkit-reviews] review requested: [Bug 27158] Add WebKit version API to Qt. : [Attachment 32804] Updated patch for generating WebKitVersion.h manually

[bugzilla-daemon at webkit.org]

robert <robert at roberthogan.net> has asked Simon Hausmann <hausmann at webkit.org>
for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32804: Updated patch for generating WebKitVersion.h manually
https://bugs.webkit.org/attachment.cgi?id=32804&action=review

------- Additional Comments from robert <robert at roberthogan.net>
Updated re Simon's comments. Haven't touched anything in other ports - don't
have their build set up. Can certainly do gtk as a separate job of work though.


Have placed WebKitVersion.h in WebCore/platform/ .. couldn't think of a better
place. Also note that I use the Version.xcconfig in WebKit/mac/Configurations
as per Mark's advice. It appears that the 'second' occurence of the webkit
version number in the UA string is maintained internally by Safari, so standard
approach is just to reuse the same webkit version number in both positions.