[webkit-reviews] review granted: [Bug 27310] Incorrect animation when trying to duplicate effect of transform-origin : [Attachment 32799] Patch with test

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 27310: Incorrect animation when trying to duplicate effect of
transform-origin
https://bugs.webkit.org/show_bug.cgi?id=27310

Attachment 32799: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32799&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 45934)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2009-07-15  Chris Marrin  <cmarrin at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27310

There's a new format being used here now. See earlier entries.

> +	   This fixes the bug by always doing component animation
> +	   as long as the function lists match. This allows CA
> +	   to animate the components and then recompose the result
> +	   into the correct matrix.

It would be nice to describe the bug that is being fixed here too.

> Index: LayoutTests/animations/transform-origin-vs-functions.html
> ===================================================================

> +	 //document.addEventListener('webkitAnimationStart', start, false);

You should remove that if it's not necessary.
r=me with those fixes.