[webkit-reviews] review denied: [Bug 27303] [WINCE] implement createThreadInternal : [Attachment 32790] patch to ThreadingWin.cpp

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has denied Joe Mason <joe.mason at torchmobile.com>'s
request for review:
Bug 27303: [WINCE] implement createThreadInternal
https://bugs.webkit.org/show_bug.cgi?id=27303

Attachment 32790: patch to ThreadingWin.cpp
https://bugs.webkit.org/attachment.cgi?id=32790&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +#if !PLATFORM(WINCE)
>  #include <process.h>
> +#endif

For?

> +#if HAVE(ERRNO_H)
> +#include <errno.h>
> +#else
> +#define NO_ERRNO
> +#endif

I'm not sure.  In a previous patch to RegisterFile we were using 'GetLastError'
instead of errno for WINCE.  Shouldn't we do the same here?  Moreover, we
should create a proper WTF abstraction for ERRNO it seems.

> +#if PLATFORM(WINCE)
> +    // This should be safe on WINCE.  On Windows desktop it is not.
> +    HANDLE threadHandle = CreateThread(0, 0,
(LPTHREAD_START_ROUTINE)wtfThreadEntryPoint, invocation, 0,
(LPDWORD)&threadIdentifier);

Why is it safe for WINCE, but not for desktop and what does it gain us?