[webkit-reviews] review granted: [Bug 27145] [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615 : [Attachment 32782] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 15 08:06:51 PDT 2009
Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145
Attachment 32782: updated patch
https://bugs.webkit.org/attachment.cgi?id=32782&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> + gchar* resultStr = g_string_free(result, FALSE);
> + printf("%s", resultStr);
> + g_free(resultStr);
I would prefer the following:
printf("%s", result->str);
g_string_free(result, TRUE);
But I am fine either way. If you feel like changing it, please do.
r=me
More information about the webkit-reviews
mailing list