[webkit-reviews] review requested: [Bug 27052] Undef ASSERT, to avoid excessive warnings : [Attachment 32780] Second try.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 15 06:05:58 PDT 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27052: Undef ASSERT, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052

Attachment 32780: Second try.
https://bugs.webkit.org/attachment.cgi?id=32780&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Changed the patch so that it only impacts the SYMBIAN platform and reflect the
intention of this change better. In addition fixed the ChangeLog (filling in
for Norbert.)

The reason for this patch is to kill the following compiler warning:

"\WebKit\JavaScriptCore\wtf\Assertions.h", line 146: Warning:  #47-D:
incompatible redefinition of macro "ASSERT" (declared at line 3029 of
"\epoc32\include\e32def.h")
  #define ASSERT(assertion) ((void)0)


More information about the webkit-reviews mailing list