[webkit-reviews] review requested: [Bug 27295] The Qt DRT pops up message boxes when javascript execution takes too long : [Attachment 32779] patch to re-implement shouldInterruptJavaScript() in Qt DRT

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27295: The Qt DRT pops up message boxes when javascript execution takes too
long
https://bugs.webkit.org/show_bug.cgi?id=27295

Attachment 32779: patch to re-implement shouldInterruptJavaScript() in Qt DRT
https://bugs.webkit.org/attachment.cgi?id=32779&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Tests like fast/js/try-catch-crash.html take a long time with debug builds and
the interpreter and may result in a message box popping up.

Qt DRT should re-implement QWebPage::shouldInterruptJavaScript() and return
false, to avoid the message boxes. The run-webkit-tests counterpart takes care
of the timeout handling.