[webkit-reviews] review denied: [Bug 27285] [Qt] New window created by clicking a link is not visible : [Attachment 32757] Force the new window to be visible

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 27285: [Qt] New window created by clicking a link is not visible
https://bugs.webkit.org/show_bug.cgi?id=27285

Attachment 32757: Force the new window to be visible
https://bugs.webkit.org/attachment.cgi?id=32757&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I believe this is incorrect.

Arora, which is based on QtWebKit has no problem showing windows when a link is
clicked.  In fact, there is a setting in Arora to control the behavior so that
opening the "new window" is done in a tab instead.  The
QWebPage|QWebFrame::createWindow(...) function is virtual and allows the client
application to create the "new window" in the manner that it prefers.  The
default implementation does nothing, thus this will have no effect on the
default implementation.  It seems that if the client is responsible for
constructing the "new window" in the manner that it deems fit, then it can be
responsible for showing it too.