[webkit-reviews] review granted: [Bug 26599] CSSHelper.h's parseURL is a function that no one should ever call : [Attachment 32729] patch for part 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 14 22:29:26 PDT 2009


mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 26599: CSSHelper.h's parseURL is a function that no one should ever call
https://bugs.webkit.org/show_bug.cgi?id=26599

Attachment 32729: patch for part 1
https://bugs.webkit.org/attachment.cgi?id=32729&action=review

------- Additional Comments from mitz at webkit.org
> +	       // FIXME: The completeURL call should be done when using the
CSSImageValue,
> +	       // not when creating it.
> +	       parsedValue =
CSSFontFaceSrcValue::create(m_styleSheet->completeURL(val->string));

The comment should say CSSFontFaceSrcValue.


More information about the webkit-reviews mailing list