[webkit-reviews] review requested: [Bug 27284] HTMLMediaElement::supportsFullscreen() should return false : [Attachment 32764] 2009-07-14 Pierre d'Herbemont <pdherbemont at apple.com>

[bugzilla-daemon at webkit.org]

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27284: HTMLMediaElement::supportsFullscreen() should return false
https://bugs.webkit.org/show_bug.cgi?id=27284

Attachment 32764: 2009-07-14  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=32764&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>

	Reviewed by NOBODY (OOPS!).

	HTMLMediaElement::supportsFullscreen() should return false
	https://bugs.webkit.org/show_bug.cgi?id=27284

	(Reverting a part of 45875)

	HTMLVideoElement::supportsFullscreen() will properly do the
	job to check if the backend supports fullscreen.

	HTMLVideoElement is the only subclass to support fullscreen
	(conditionnaly). HTMLAudioElement fullscreen is not supported
	and is a different kind of fullscreen, if it comes to be wanted.

	No test can be done currently given that none of the backend
	supports fullscreen.

	* html/HTMLMediaElement.cpp:
	* html/HTMLMediaElement.h:
	(WebCore::HTMLMediaElement::supportsFullscreen):
---
 3 files changed, 26 insertions(+), 7 deletions(-)