[webkit-reviews] review denied: [Bug 27225] Change all Noncopyable inheriting to publicly inheriting : [Attachment 32668] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 14 15:34:20 PDT 2009
Darin Adler <darin at apple.com> has denied Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27225: Change all Noncopyable inheriting to publicly inheriting
https://bugs.webkit.org/show_bug.cgi?id=27225
Attachment 32668: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32668&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> -struct OpaqueJSClassContextData : Noncopyable {
> +struct OpaqueJSClassContextData : public Noncopyable {
struct inheritance is already public, so this change is not needed. There are
tons of other cases like this. Please don't make those changes since they
aren't needed. Otherwise this seems fine. review- because I'd like to see the
patch without the unneeded changes.
More information about the webkit-reviews
mailing list