[webkit-reviews] review granted: [Bug 26816] Selection changed by indent : [Attachment 32487] change due to the resubmission for 27038
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 14 15:09:24 PDT 2009
Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816
Attachment 32487: change due to the resubmission for 27038
https://bugs.webkit.org/attachment.cgi?id=32487&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Should have a bug:
+ // FIXME: we need to deal with the case where there is no li (malformed
HTML)
+ if (!selectedListItem->hasTagName(liTag))
+ return false;
024 \ No newline at end of file
Needs an arg name for the Node*:
59 void indentIntoBlockquote(const VisiblePosition&, const
VisiblePosition&, RefPtr<Element>&, Node*);
Looks fine otherwise. Thanks!
More information about the webkit-reviews
mailing list