[webkit-reviews] review granted: [Bug 26983] tst_qwebpage segfaults : [Attachment 32717] Fix the QSize/IntSize mismatch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 14 09:39:45 PDT 2009


Zack Rusin <zack at kde.org> has granted Adam Treat <treat at kde.org>'s request for
review:
Bug 26983: tst_qwebpage segfaults
https://bugs.webkit.org/show_bug.cgi?id=26983

Attachment 32717: Fix the QSize/IntSize mismatch
https://bugs.webkit.org/attachment.cgi?id=32717&action=review

------- Additional Comments from Zack Rusin <zack at kde.org>
Personally I'd prefer this in IntSizeQt.cpp but the issue is that it's
impossible to detect whether it's QSize() or QSize(-1, -1). We'd like to
convert the first one to QSize(0, 0) but not the latter (because it will mess
up conversions after doing any kind of subtraction of IntSizes). So I think
this will do for now.


More information about the webkit-reviews mailing list