[webkit-reviews] review granted: [Bug 27262] Chromium: HTML exported isn't marked as being UTF-8 : [Attachment 32713] Patch to mark clipboard HTML as UTF-8

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 14 09:38:26 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Avi Drissman
<avi at drissman.com>'s request for review:
Bug 27262: Chromium: HTML exported isn't marked as being UTF-8
https://bugs.webkit.org/show_bug.cgi?id=27262

Attachment 32713: Patch to mark clipboard HTML as UTF-8
https://bugs.webkit.org/attachment.cgi?id=32713&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +2009-07-14  Avi Drissman  <avi at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Explicitly mark the HTML generated for the Mac as being UTF-8
encoded.
> +	   The Windows clipboard format is explicitly documented as being
UTF-8,
> +	   and all Linux apps assume UTF-8. On the Mac, though, unless
otherwise
> +	   indicated, ISO/IEC 8859-1 is assumed, which is wrong.

nit: Your ChangeLog should include a link to this bug.

Otherwise, R=me


More information about the webkit-reviews mailing list