[webkit-reviews] review requested: [Bug 27076] [WINCE] Move date related symbols to DateExtras.h : [Attachment 32712] DateExtras

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 14 08:09:45 PDT 2009


Kwang Yul Seo <kwangyul.seo at gmail.com> has asked Eric Seidel <eric at webkit.org>
for review:
Bug 27076: [WINCE] Move date related symbols to DateExtras.h
https://bugs.webkit.org/show_bug.cgi?id=27076

Attachment 32712: DateExtras
https://bugs.webkit.org/attachment.cgi?id=32712&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
Okay. I removed the code from the public without license. Instead, I copied the
implementation of WinCE time functions from wxWidgets-2.8.10 and modified them
accordingly. wxWidgets is licensed under wxWindows Licence which is essentially
LGPL, so I think there is no license problem here now.

http://www.wxwidgets.org/about/newlicen.htm


I also run the new lint tool and fixed some style errors. I am still not
accustomed to the WebKit coding convention, there might be more errors.

cpplint.py DateExtras.*
Done processing DateExtras.cpp
Done processing DateExtras.h
Total errors found: 0


More information about the webkit-reviews mailing list