[webkit-reviews] review denied: [Bug 27210] [Qt] Add an API to get a list of installed plugins : [Attachment 32656] patch

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has denied Jakub Wieczorek <faw217 at gmail.com>'s
request for review:
Bug 27210: [Qt] Add an API to get a list of installed plugins
https://bugs.webkit.org/show_bug.cgi?id=27210

Attachment 32656: patch
https://bugs.webkit.org/attachment.cgi?id=32656&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
We talked this over in #qtwebkit and believe this is a great addition to the
API.  However, there might be confusion with two different functions that
appear to do the same thing: plugins() and installedPlugins().	With this in
mind, how about a method such as 'QList<QWebPluginFactory::Plugin>
QWebPage::plugins(enum);' where the enum would differentiate between system
plugins that are picked up by scanning netscape plugin directories and those
plugins that are installed via QWebPluginFactory.

With this change, perhaps QWebPluginFactory::Plugin should have it's own class
such as QWebPlugin.  I'm not sure.

Eventually, it'd be nice to add API to set/get the preferred plugin for a
particular mimetype and also to query/set the directories searched for system
plugins.  Some ideas for how to do that are here:

http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=adam/netscape-
plugin-manager

Cheers,
Adam