[webkit-reviews] review granted: [Bug 24187] RTL: tooltip does not get its directionality from its element's directionality : [Attachment 31953] patch w/o layout test (version 2)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 24187: RTL: tooltip does not get its directionality from its element's
directionality
https://bugs.webkit.org/show_bug.cgi?id=24187

Attachment 31953: patch w/o layout test (version 2)
https://bugs.webkit.org/attachment.cgi?id=31953&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    RenderObject* renderer = m_innerNonSharedNode->renderer();
> +    if (renderer)
> +	   dir = renderer->style()->direction();

Could have defined the variable inside the if statement.

> +		   RenderObject* renderer = titleNode->renderer();
> +		   if (renderer)
> +		       dir = renderer->style()->direction();

Ditto.

> +    }
> +    else if (isEqual(WebElementTitleKey, key)) {

In WebKit coding style, the else goes on the same line as the brace.

> +void WebChromeClient::setToolTip(const String& toolTip, TextDirection /* dir
*/)

We normally omit the name entirely rather than having it included but commented
out.

r=me