[webkit-reviews] review granted: [Bug 27087] Add New Configuration Flag for Redistributable Windows Build : [Attachment 32664] Revise to use vsprops instead of project modifications. Use WIN_CAIRO label instead of WIN_REDISTRIBUTABLE.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 27087: Add New Configuration Flag for Redistributable Windows Build
https://bugs.webkit.org/show_bug.cgi?id=27087

Attachment 32664: Revise to use vsprops instead of project modifications.  Use
WIN_CAIRO label instead of WIN_REDISTRIBUTABLE.
https://bugs.webkit.org/attachment.cgi?id=32664&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebCore/WebCore.vcproj/WebCore.vcproj	(working copy)
> @@ -183,8 +183,9 @@
>		</Configuration>
>		<Configuration
>			Name="Debug_Cairo|Win32"
> +			IntermediateDirectory="$(ConfigurationName)"

I don't think you meant to add this.

> +++ WebKit/win/ChangeLog	(working copy)
> @@ -1,3 +1,23 @@
> +2009-07-13  Brent Fulgham  <bfulgham at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add new configuration flag for redistributable Windows build.
> +	   https://bugs.webkit.org/show_bug.cgi=27087
> +
> +	   * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to
> +	     Debug_Cairo and Release_Cairo targets.
> +
> +2009-07-13  Brent Fulgham  <bfulgham at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add new configuration flag for redistributable Windows build.
> +	   https://bugs.webkit.org/show_bug.cgi=27087
> +
> +	   * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to the
> +	     Release_Cairo and Debug_Cairo targets.

Double double!

r=me