[webkit-reviews] review denied: [Bug 14272] Cannot change the height of the Web Inspector when docked on Windows : [Attachment 32606] Height Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32606: Height Patch
https://bugs.webkit.org/attachment.cgi?id=32606&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
It's really great to see this getting fixed!

I have a few comments about the general approach to this fix:

I think it's not good to be duplicating more code from WebKit/mac in
WebKit/win. A much better way to fix this would be to move most of the
WebKit/mac code down into WebCore, where it can be shared by WebKit/win. The
idea would be to have all the logic down in WebCore, and only call up to WebKit
when absolutely necessary. A rough division of responsibility would be:

WebCore:
 * Calculates new window sizes
 * Saves/restores window size preference

WebKit:
 * Actually resizes the windows to the dimensions specified by WebCore

So I think you should redo this in at least two parts:

1) Move most WebKit/mac logic related to the window size down to WebCore
2) Add in the WebKit/win bits

Please feel free to ask more questions here in the bug!