[webkit-reviews] review requested: [Bug 27202] Inspector: Cookies in Storage Panel : [Attachment 32643] Add Cookies to Database Panel

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27202: Inspector: Cookies in Storage Panel
https://bugs.webkit.org/show_bug.cgi?id=27202

Attachment 32643: Add Cookies to Database Panel
https://bugs.webkit.org/attachment.cgi?id=32643&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
The first take!  Here are some comments:

- I have little to no image skills.  If anyone could help make a better image
or point me to someone who can that would be awesome!  I just made a new image
to get the proper CSS rules out of the way.
- The Cookie TreeElement disappears if the user has the Inspector open and
navigates to another page or reloads the current page.	I don't know which
functions the Inspector is calling.  It doesn't seem to call the Panel's show()
or populateInterface() methods on page loads, only when the currentPanel is
changed to the Databases panel or the WebInspector is opened after being
closed.
- This is an all js version. I hope to work up to switching over to C++ to
access more of the cookie data and to do some processing without having to
resort to evaluating code in the inspected window.
- A page has only 1 set of cookies but can have >1 DOMStorage and >1 Databases.
 This is why WebInspector.DatabasesPanel._cookies is one object that is
constantly updated, and why nothing is passed into the CookieView.  Whenever
the view needs the list of cookies it must resort to checking the inspected
page's document.cookie string.	A C++ version would probably make this cleaner.

- The Datagrid has the ability to delete cookies and will automatically update
the display once a cookie has been deleted.  Again this jumps into the
inspected window to run a command.
- I tried to keep in line with the coding standards from DOMStorage and
Databases as much as possible.
- I used the Apple Copyright with the year 2009.  However, I'm not actually
affiliated with Apple.	I just noticed writing this bug report that it says
"please also add your copyright (name and year) to the relevant files".  Is the
Apple Copyright fine to keep or should I replace it with my own?

If you want to test it out you can easily add/remove cookies, and at the same
time get a quick reminder on how to work with them via javascript at this site.
 I've been using it for testing and its helped me squash some bugs:
http://www.quirksmode.org/js/cookies.html

Thanks for taking the time to look this over.  Cheers!