[webkit-reviews] review granted: [Bug 27171] [Gtk] REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html : [Attachment 32605] implement grab-focus

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27171: [Gtk] REGRESSION (r45440): fails at
fast/events/frame-programmatic-focus.html
https://bugs.webkit.org/show_bug.cgi?id=27171

Attachment 32605: implement grab-focus
https://bugs.webkit.org/attachment.cgi?id=32605&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> -	   core(webView)->focusController()->setActive(frame);
> -	   core(webView)->focusController()->setFocused(true);
> +	   focusController->setActive(true);
> +	   focusController->setFocused(true);

The only change that makes me a bit nervous is going from frame to true here. I
believe there might have been a reason to not set it unconditionally? r=me, but
please either revert this specific change, or add a comment here on the bug so
that we have a way of tracking this down.