[webkit-reviews] review granted: [Bug 27180] Cleanup DOM Storage dependencies. : [Attachment 32617] patch 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 11 15:11:42 PDT 2009


Darin Adler <darin at apple.com> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32617: patch 1
https://bugs.webkit.org/attachment.cgi?id=32617&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Having the reference counter be a friend class and a private destructor does
seem slightly tighter than our usual reference counting idiom, which is good.

If it was me I wouldn't call these "really bad dependencies" or say "such a
tangled mess" -- I would intend say something factual about how many extra
includes there are and let the reader decide how bad it was.


More information about the webkit-reviews mailing list