[webkit-reviews] review granted: [Bug 27163] Fix memory leak in V8 bindings : [Attachment 32591] patch to avoid leaking contexts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 10 23:30:41 PDT 2009


Adam Barth <abarth at webkit.org> has granted Mads Ager <ager at chromium.org>'s
request for review:
Bug 27163: Fix memory leak in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27163

Attachment 32591: patch to avoid leaking contexts
https://bugs.webkit.org/attachment.cgi?id=32591&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
These seem like two independent changes, but that's ok.  I don't understand why
calling initContextIfNeeded() in clearForNavigation() leads to a leak, but it
makes sense that this isn't needed because all the other entry points are super
excited about making sure the context is initialized before they use it.

I'm r+ing this, but it would be helpful for Dimitri to give his opinion as
well.


More information about the webkit-reviews mailing list