[webkit-reviews] review denied: [Bug 27170] drawImage method of HTMLCanvasElement to accept HTMLVideoElement as argument : [Attachment 32603] patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 27170: drawImage method of HTMLCanvasElement to accept HTMLVideoElement as
argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32603: patch
https://bugs.webkit.org/attachment.cgi?id=32603&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +	       if (ec != 0) {
> +		   V8Proxy::setDOMException(ec);
> +		   return notHandledByInterceptor();
> +	       }

This probably should be

if (ec)
   return throwError(ec);

> +	       if (ec != 0) {
> +		   V8Proxy::setDOMException(ec);
> +		   return notHandledByInterceptor();
> +	       }

Ditto.

> +	       break;
> +	   default:
> +	       V8Proxy::throwError(V8Proxy::SyntaxError, "drawImage: Invalid
number of arguments");
> +	       return v8::Undefined();

return throwError(V8Proxy::SyntaxError, "drawImage: Invalid number of
arguments");

> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 45742)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,12 @@
> +2009-07-07  Alpha Lam  <hclam at chromium.org>
> +
> +	   Reviewed by NOBODY(OOPS!).
> +
> +	   Changed CanvasRenderingContext2DDrawImage to accept HTMLVideoElement

> +	   as a parameter of drawImage of HTMLCanvasElement.
> +


Wrong ChangeLog? Should be WebCore/ChangeLog.