[webkit-reviews] review granted: [Bug 27167] bugzilla-tool: hide help for unsupported commands : [Attachment 32599] Patch v2

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27167: bugzilla-tool: hide help for unsupported commands
https://bugs.webkit.org/show_bug.cgi?id=27167

Attachment 32599: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32599&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great.

I would make:
if command_object.requires_local_commits and not
self.scm().supports_local_commits():
 591		 error(command_name + " requires local commits.")

more verbose.  You could spit out the SCM.display_name() as well as possibly
the root directory we detected for the SCM.

Thanks!