[webkit-reviews] review requested: [Bug 27172] bugzilla-tool: create CommitMessage class : [Attachment 32604] Patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27172: bugzilla-tool: create CommitMessage class
https://bugs.webkit.org/show_bug.cgi?id=27172

Attachment 32604: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32604&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

Create a CommitMessage class to encapsulate related code.

* Scripts/bugzilla-tool:
(bug_id_from_commit_message): Moved to
CommitMessage.parse_bug_id().
(commit_message_for_this_commit): Return a CommitMessage.
(ApplyPatchesFromBug.apply_patches): Use CommitMessage.message().
(LandPatchesFromBugs.build_and_commit): Ditto.
(CommitMessageForCurrentDiff.execute): Ditto.
(PostCommitsAsPatchesToBug.execute): Switched from
Git.commit_message_for_commit() to
Git.commit_message_for_local_commit().	Switched from
bug_id_from_commit_message() to CommitMessage.parse_bug_id().

* Scripts/modules/scm.py:
(first_non_empty_line_after_index): Added.
(CommitMessage.__init__): Added.
(CommitMessage.body): Added.
(CommitMessage.description): Added.
(CommitMessage.message): Added.
(CommitMessage.parse_bug_id): Added.  Moved from
bug_id_from_commit_message() in bugzilla-tool.
(Git.commit_message_for_local_commit): Renamed from
commit_message_for_commit().  Return a CommitMessage.
---
 3 files changed, 87 insertions(+), 21 deletions(-)