[webkit-reviews] review denied: [Bug 27167] bugzilla-tool: hide help for unsupported commands : [Attachment 32596] Patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27167: bugzilla-tool: hide help for unsupported commands
https://bugs.webkit.org/show_bug.cgi?id=27167

Attachment 32596: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32596&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think this is great, except I would have defaulted "requires_local_commits"
to False, and made it a parameter to the Command constructor (__init__), then
you only need to change about 4 lines of code, instead of all the ones you did
here.

I guess I should r- this since I wouldn't recommend committing as-is, but in
general I think this feature is great!	I would have just used a slightly
different python approach.

basically now:

Command.__init__(self, ..., requires_local_commits=False)

and the few commands which do, call:

	Command.__init__(self, 'r+\'d patches on a bug', 'BUGID',
requires_local_commits=True)