[webkit-reviews] review requested: [Bug 27158] Add WebKit version API to Qt. : [Attachment 32583] Initial Patch

[bugzilla-daemon at webkit.org]

robert <robert at roberthogan.net> has asked  for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32583: Initial Patch
https://bugs.webkit.org/attachment.cgi?id=32583&action=review

------- Additional Comments from robert <robert at roberthogan.net>
The approach is to treat WebCore/Configurations/Version.xcconfig as the
definitive place for version information. If parsing that file fails, Qt will
default to a version number hardcode in WebKit.pri, and failing that a version
hardcoded in qwebkitversion.cpp.

Things I'm not sure about yet:

- Choice of hard-coded version number if parsing Version.xcconfig fails -
currently 531.3.
- Have only tested the following qmake macro on Linux. It should work on all
other platforms, but not 100% certain.

+MAJOR_VERSION = $$system(perl WebKitTools/Scripts/get-webkit-version --major \

+			  WebCore/Configurations/Version.xcconfig)