[webkit-reviews] review denied: [Bug 27136] [Qt] Webkit hangs when executing an infinite JavaScript loop : [Attachment 32568] Replace the signal with QMetaObject::invokeMethod

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32568: Replace the signal with QMetaObject::invokeMethod
https://bugs.webkit.org/attachment.cgi?id=32568&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> Index: WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
> ===================================================================
> --- WebKit/qt/WebCoreSupport/ChromeClientQt.cpp	(revision 45709)
> +++ WebKit/qt/WebCoreSupport/ChromeClientQt.cpp	(working copy)
> @@ -288,8 +288,7 @@
>  
>  bool ChromeClientQt::shouldInterruptJavaScript()
>  {
> -    notImplemented();
> -    return false;
> +    return QMetaObject::invokeMethod(m_webPage, "shouldInterruptJavaScript",
Qt::DirectConnection);

I don't think this is correct, invokeMethod returns a boolean indicating
whether the function could be called or not, but the return value itself is
placed in the fourth argument of invokeMethod.

Also a unit test would be good for this :)

An alternate solution would be to use QWebPage::supportsExtension and
QWebPage::extension. Holger, do you have any preference?





I