[webkit-reviews] review granted: [Bug 27137] REGRESSION (r44311): Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor() -> FrameView::layout() : [Attachment 32551] Make lock-scroll-to-anchor a function of FrameView, and perform it as a post-layout task

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 27137: REGRESSION (r44311): Reproducible crash due to infinite recursion
into FrameLoader::gotoAnchor() -> FrameView::layout()
https://bugs.webkit.org/show_bug.cgi?id=27137

Attachment 32551: Make lock-scroll-to-anchor a function of FrameView, and
perform it as a post-layout task
https://bugs.webkit.org/attachment.cgi?id=32551&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>


> +void FrameView::keepScrolledToAnchorNode(Node* anchorNode)

I'm not a big fan of this method name; maybe something like
maintainScrollPositionToAnchorNode?

> +    if (anchorNode != m_frame->document())
> +	   rect = anchorNode->getRect();

getRect(true) will make this transform-friendly!

r=me