[webkit-reviews] review denied: [Bug 27136] [Qt] Webkit hangs when executing an infinite JavaScript loop : [Attachment 32539] Add UI asking the user if to stop running the script

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 10 07:35:06 PDT 2009


Holger Freyther <zecke at selfish.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32539: Add UI asking the user if to stop running the script
https://bugs.webkit.org/attachment.cgi?id=32539&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Yael, we may not add new virtual methods as this will change the vtable and
break ABI to previous versions. One common way is to create a new method with
return value and use QMetaObject::invokeMethod. I assume Qt Software has an
internal document describing what to do now. Besides that the patch looks fine.


More information about the webkit-reviews mailing list