[webkit-reviews] review granted: [Bug 27133] [Chromium] Upstream RGBColor : [Attachment 32538] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 9 20:44:44 PDT 2009
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27133: [Chromium] Upstream RGBColor
https://bugs.webkit.org/show_bug.cgi?id=27133
Attachment 32538: patch
https://bugs.webkit.org/attachment.cgi?id=32538&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/bindings/v8/RGBColor.cpp
...
> + unsigned int value = (m_rgbColor >> 16) & 0xFF;
> + return CSSPrimitiveValue::create(value, CSSPrimitiveValue::CSS_NUMBER);
nit: i think the prevailing style in webkit is to just use "unsigned" instead
of
"unsigned int"
otherwise, R=me
More information about the webkit-reviews
mailing list