[webkit-reviews] review canceled: [Bug 27051] Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled : [Attachment 32410] Code patch for Registerfile ccp and h

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has canceled Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27051: Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled
https://bugs.webkit.org/show_bug.cgi?id=27051

Attachment 32410: Code patch for Registerfile ccp and h
https://bugs.webkit.org/attachment.cgi?id=32410&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'll have to check into whether this works - I don't remember whether there are
special alignment or lazy commit requirements.

But I also noticed that PLATFORM(SYMBIAN) uses fastMalloc in place of VM
allocation inside Collector.cpp. That's definitely bugus - the GC counts on the
guaranteed alignment provided by vm_map, VirtualAlloc and posix_memalign.
Failing to meet the alignment requirements will lead to random crashes. If
Symbian has no way to get aligned memory chunks, it needs to do a trick to fix
up the alignment, like the mmap() code path.