[webkit-reviews] review granted: [Bug 27140] Add a preference key to make Web Inspector detach/attach by default : [Attachment 32545] Windows Patch

[bugzilla-daemon at webkit.org]

Alice Liu <alice.liu at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 27140: Add a preference key to make Web Inspector detach/attach by default
https://bugs.webkit.org/show_bug.cgi?id=27140

Attachment 32545: Windows Patch
https://bugs.webkit.org/attachment.cgi?id=32545&action=review

------- Additional Comments from Alice Liu <alice.liu at apple.com>
> @@ -322,6 +324,9 @@ void WebInspectorClient::showWindowWitho
>      ASSERT(m_webView);
>      ASSERT(m_inspectedWebViewHwnd);
>  
> +    InspectorController::Setting shouldAttach =
m_inspectedWebView->page()->inspectorController()->setting(inspectorStartsAttac
hedName);
> +    m_shouldAttachWhenShown = (shouldAttach.type() ==
InspectorController::Setting::BooleanType) ? shouldAttach.booleanValue() :
false;
> +
>      if (!m_shouldAttachWhenShown) {
>	   // Put the Inspector's WebView inside our window and show it.
>	   m_webView->setHostWindow(reinterpret_cast<OLE_HANDLE>(m_hwnd));

bdash wants you to remove the extraneous parents around the condition before
the question mark

r=me