[webkit-reviews] review canceled: [Bug 27011] [Gtk] Implement support for get_index_in_parent : [Attachment 32456] getindexinparent.patch

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has canceled Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 27011: [Gtk] Implement support for get_index_in_parent
https://bugs.webkit.org/show_bug.cgi?id=27011

Attachment 32456: getindexinparent.patch
https://bugs.webkit.org/attachment.cgi?id=32456&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -    // FIXME: This needs to be implemented.
> -    notImplemented();
> +    AccessibilityObject* coreObject = core(object);
> +    AccessibilityObject* parent = coreObject->parentObject();
> +
> +    g_return_val_if_fail (parent, 0);

Just a nit: this needs to be in "if" since we're dealing with WebCore objects.

I'll clear the review flag for now until we sort out Joanmarie's findings.