[webkit-reviews] review granted: [Bug 27128] Make Widget Ref-Counted. : [Attachment 32533] New Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 27128: Make Widget Ref-Counted.
https://bugs.webkit.org/show_bug.cgi?id=27128

Attachment 32533: New Patch
https://bugs.webkit.org/attachment.cgi?id=32533&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Typo in ChangeLog:

"setWidget() now takes a PassRefPtr. Also eemoved the manual ref of "

"eemoved" should be "removed".

ScrollView::platformAddChild never takes ownership of the Widget, so I don't
think you needed to change any of those implementations. Those should just be
platformAddChild(Widget*) still.  You can undo that change and avoid having to
touch a bunch of ScrollView port files.

With those changes, r=me!