[webkit-reviews] review granted: [Bug 27123] Full page zoom breaks remaining and elapsed time display in the <video> controller. : [Attachment 32531] patch v2.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27123: Full page zoom breaks remaining and elapsed time display in the
<video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

Attachment 32531: patch v2.
https://bugs.webkit.org/attachment.cgi?id=32531&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>


> +	   We are changing the size of the time remaining and time ellapsed
field, to

Typo: "ellapsed"

> +	   The following patch fixes that problem by using a cloned style on
which we

"This change", not "The following patch", since the changelog needs to read
well after you commit :)


> +    RefPtr<RenderStyle> style = styleForElement();
> +    renderer()->setStyle(style.get());

To reduce ref churn, you could just do

 renderer()->setStyle(styleForElement());