[webkit-reviews] review denied: [Bug 27103] Upstream V8NPObject.h and V8NPObject.cpp : [Attachment 32488] Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other files that reference the old filename/function names.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 9 12:54:35 PDT 2009
Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27103: Upstream V8NPObject.h and V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27103
Attachment 32488: Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other
files that reference the old filename/function names.
https://bugs.webkit.org/attachment.cgi?id=32488&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Thanks for doing this! Just two minor style nits:
> +enum InvokeFunctionType {
> + INVOKE_METHOD = 1,
> + INVOKE_CONSTRUCT = 2,
> + INVOKE_DEFAULT = 3
> +};
InvokeError, etc.
> + return v8::Local<v8::Value>(); // Do not intercept the call.
return notHandledByInterceptor();
More information about the webkit-reviews
mailing list