[webkit-reviews] review requested: [Bug 26953] [V8] Do not do unnecessary handles casts and inline couple of methods : [Attachment 32525] Do not generate long boolen expression unless ASSERTs enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 12:16:03 PDT 2009


anton muhin <antonm at chromium.org> has asked  for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32525: Do not generate long boolen expression unless ASSERTs enabled
https://bugs.webkit.org/attachment.cgi?id=32525&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Mads, thanks a lot for another round!

I'd easily remove ASSERT---I do agree it fishy---I just wanted to keep it
closer to the original version.  So if you repeat it again, next patch would be
w/o ASSERT :)  For now I'm just putting boolean generation under proper
condition.


More information about the webkit-reviews mailing list