[webkit-reviews] review requested: [Bug 26903] Need to enable CHANNEL_MESSAGING by default : [Attachment 32523] Patch with enabled security test and removing merge conflict.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 10:43:32 PDT 2009


Andrew Wilson <atwilson at google.com> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 26903: Need to enable CHANNEL_MESSAGING by default
https://bugs.webkit.org/show_bug.cgi?id=26903

Attachment 32523: Patch with enabled security test and removing merge conflict.
https://bugs.webkit.org/attachment.cgi?id=32523&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Sigh, fixed merge errors - tragically git didn't notice that I'd committed a
file with a merge conflict.

I enabled that test - as I mentioned on IRC, you can no longer use a
MessageChannel constructor from a closed frame, so now I simplified the test to
just check for a thrown exception.

I was able to build on Windows just fine - what files were you concerned were
missing from the vcproj file?


More information about the webkit-reviews mailing list