[webkit-reviews] review denied: [Bug 27087] Add New Configuration Flag for Redistributable Windows Build : [Attachment 32465] Add WIN_REDISTRIBUTABLE flag for builds

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 27087: Add New Configuration Flag for Redistributable Windows Build
https://bugs.webkit.org/show_bug.cgi?id=27087

Attachment 32465: Add WIN_REDISTRIBUTABLE flag for builds
https://bugs.webkit.org/attachment.cgi?id=32465&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   * WebCore.vcproj/WebCore.vcproj: Define WIN_REDISTRIBUTABLE for
> +	     the Release_Cairo and Debug_Cairo targets.

I think it would be better to make a WebCoreRedistributable.vsprops file and
put the definition in there. We want to keep as much stuff out of the .vcproj
as possible!

The other code changes look fine. I'm not so sure about the WIN_REDISTRIBUTABLE
name, though. It seems a bit too vague (not that the existing "WIN" name is any
better!). Maybe we need a more "marketing-ish" name for this port?