[webkit-reviews] review denied: [Bug 25205] XMLHttpRequest instance is not an instanceof XMLHttpRequest : [Attachment 32499] DOMConstructorObject approach.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 9 08:18:21 PDT 2009
Darin Adler <darin at apple.com> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205
Attachment 32499: DOMConstructorObject approach.
https://bugs.webkit.org/attachment.cgi?id=32499&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +#ifndef NDEBUG
> + virtual ~DOMConstructorObject();
> +#endif
What's the idea here? I don't see any definition of this destructor, so it
seems like the change won't link. Have you tested yet?
Otherwise, everything looks great!
More information about the webkit-reviews
mailing list