[webkit-reviews] review requested: [Bug 27072] Split StorageNamespace and StorageArea into an interface and implementation : [Attachment 32486] Fix build in release mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 8 16:27:59 PDT 2009


Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27072: Split StorageNamespace and StorageArea into an interface and
implementation
https://bugs.webkit.org/show_bug.cgi?id=27072

Attachment 32486: Fix build in release mode
https://bugs.webkit.org/attachment.cgi?id=32486&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
I'm not sure why this showed up in release mode and not debug (probably
optimizations?), but there was a build error in the last patch.  To fix it, I
defined 2 virtual functions in StorageArea and made StorageAreaSync use a
StorageArea* rather than a StroageAreaImpl* which removed some complex
dependencies.


More information about the webkit-reviews mailing list