[webkit-reviews] review denied: [Bug 26940] [Chromium] Add a SQLite VFS for Chromium : [Attachment 32476] win patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32476: win patch
https://bugs.webkit.org/attachment.cgi?id=32476&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looking much prettier -- two minor issues below:

> +String SQLiteFileSystem::appendDatabaseFileNameToPath(const String& path,
const String& fileName)
> +{
> +    if (path.isEmpty())
> +	   return fileName;
> +    else
> +	   return path + "\\" + fileName;
> +}

Whoops. This is a Windows-ism. Can we use FileSystem.h magic here?

> +int chromiumDelete(sqlite3_vfs* vfs, const char* fileName, int syncDir)

unused param syncDir?