[webkit-reviews] review granted: [Bug 27094] [Chromium] Upstream V8 npruntime bindings : [Attachment 32474] patch2

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27094: [Chromium] Upstream V8 npruntime bindings
https://bugs.webkit.org/show_bug.cgi?id=27094

Attachment 32474: patch2
https://bugs.webkit.org/attachment.cgi?id=32474&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me, with nits:

> +// Commenting out the locks to avoid dependencies on chrome for now.
> +// Need a platform abstraction which we can use.
> +// static Lock StringIdentifierMapLock;
> +

Remove commented code.

> +// FIXME: Consider removing locks if we're singlethreaded already.
> +// static Lock IntIdentifierMapLock;

Ditto.

> +	   // AutoLock safeLock(StringIdentifierMapLock);

Ditto.

> +    // AutoLock safeLock(IntIdentifierMapLock);

Ditto.