[webkit-reviews] review granted: [Bug 26903] Need to enable CHANNEL_MESSAGING by default : [Attachment 32461] Patch addressing ap's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 8 11:29:59 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26903: Need to enable CHANNEL_MESSAGING by default
https://bugs.webkit.org/show_bug.cgi?id=26903

Attachment 32461: Patch addressing ap's comments
https://bugs.webkit.org/attachment.cgi?id=32461&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +<<<<<<< HEAD:LayoutTests/ChangeLog

> +=======

Please fix conflict markers before landing.

Does the Visual Studio project actually build? I'm not sure if it has all the
necessary source files in it.

Oh, and please also enable
LayoutTests/http/tests/security/MessagePort/event-listener-context.html-disable
d.

I'm going to say r=me now, but please address these comments.


More information about the webkit-reviews mailing list