[webkit-reviews] review granted: [Bug 27072] Split StorageNamespace and StorageArea into an interface and implementation : [Attachment 32435] v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 8 10:21:00 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27072: Split StorageNamespace and StorageArea into an interface and
implementation
https://bugs.webkit.org/show_bug.cgi?id=27072

Attachment 32435: v1
https://bugs.webkit.org/attachment.cgi?id=32435&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/storage/StorageArea.cpp

> +#if PLATFORM(CHROMIUM)
> +#else
> +    return StorageAreaImpl::create(storageType, origin, syncManager);
>  #endif

I think this should be #if !PLATFORM(CHROMIUM) to avoid the #else, or
perhaps you should add a similar FIXME comment there as you do below:


> Index: WebCore/storage/StorageNamespace.cpp

> +#if PLATFORM(CHROMIUM)
> +    // FIXME: Implement.
> +#else
> +    return StorageNamespaceImpl::localStorageNamespace(path);
> +#endif

Otherwise, looks good to me.  R=me


More information about the webkit-reviews mailing list