[webkit-reviews] review denied: [Bug 25205] XMLHttpRequest instance is not an instanceof XMLHttpRequest : [Attachment 32434] This also fixes for XSTLProcessor, Audio, etc.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32434: This also fixes for XSTLProcessor, Audio, etc.
https://bugs.webkit.org/attachment.cgi?id=32434&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This seems OK, but not great. The design here is supposed to be that derived
classes override createStructure if the base class version doesn't work right.
Leaving behind a createStructure function that does the wrong thing and relying
on the callers to call the correct one seems unnecessarily fragile to me. To
share code, we could create a new base class, derived from DOMObject, and have
all the constructor classes derive from this, and it would override
createStructure to work properly.

Would you be willing to try that approach?

review- for now, but I'm open to landing this version if you don't like my
suggestion and can convince me.